Update @actions/artifact to latest version, includes symlink and timeout fixes #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacaovsnc
previously approved these changes
Oct 7, 2024
joshmgross
previously approved these changes
Oct 7, 2024
joshmgross
previously approved these changes
Oct 7, 2024
joshmgross
approved these changes
Oct 7, 2024
This was referenced Oct 7, 2024
7 tasks
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
May 4, 2025
### Briefly, what does this PR introduce? This PR unpins a github action since with [v4.4.1](https://github.com/actions/upload-artifact/releases/tag/v4.4.1), this issue is resolved (actions/upload-artifact#625). ### What kind of change does this PR introduce? - [x] Bug fix (issue: technical debt) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to rollback a toolkit version for artifact because we had a couple regressions:
This PR includes updates to toolkit to fix those regressions:
Extra integration tests were added to cover symlinked files and expected behavior.
Also, bumps the toolkit's
@actions/coreversion as well.